Skip to content

refactor: replace in(s)/out(s) with input(s)/output(s)#392

Merged
maltemoeser merged 2 commits intocitp:v0.6from
maltemoeser:refactor/in-out-api-change-patched
May 13, 2020
Merged

refactor: replace in(s)/out(s) with input(s)/output(s)#392
maltemoeser merged 2 commits intocitp:v0.6from
maltemoeser:refactor/in-out-api-change-patched

Conversation

@maltemoeser
Copy link
Copy Markdown
Member

@maltemoeser maltemoeser commented Apr 7, 2020

Changes in(s)/out(s) to input(s)/output(s) to avoid confusion with incoming and outgoing funds (i.e., outputs correspond to incoming funds, inputs to outgoing funds).

Also prints a deprecation warning for users to switch to the consistent syntax.

@maltemoeser maltemoeser added this to the v0.6 milestone May 6, 2020
Also prints a deprecation warning for users to switch to the consistent syntax.

# Conflicts:
#	blockscipy/src/scripts/equiv_address/equiv_address_proxy_py.cpp
@maltemoeser maltemoeser force-pushed the refactor/in-out-api-change-patched branch from fc4a130 to 74d8a72 Compare May 13, 2020 01:39
@maltemoeser
Copy link
Copy Markdown
Member Author

Rebased (#387 is now in v0.6)

@maltemoeser maltemoeser marked this pull request as ready for review May 13, 2020 01:40
@maltemoeser maltemoeser merged commit 9cfe326 into citp:v0.6 May 13, 2020
@maltemoeser maltemoeser deleted the refactor/in-out-api-change-patched branch May 13, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant