Skip to content

feat: Add support for Tags#9

Merged
jacdavi merged 4 commits intomainfrom
tagging
May 1, 2025
Merged

feat: Add support for Tags#9
jacdavi merged 4 commits intomainfrom
tagging

Conversation

@jacdavi
Copy link
Copy Markdown
Collaborator

@jacdavi jacdavi commented Apr 29, 2025

🗣 Description

Adds a variable to set tags on all ScubaConnect resources.
Tags are applied via policy and remediation tasks in Terraform.
This is done to avoid conflicts with other policies that may modify tags (each resource in terraform is configured to ignore tag changes).

💭 Motivation and context

This allows setting tags on resources which helps with organization.

🧪 Testing

  • Tested deploying a new instance and confirmed tags were applied
  • Tested adding a tag to an existing deployment and confirmed that tag was added to existing resources

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@jacdavi jacdavi added improvement This issue or pull request will add new or improve existing functionality gearconnect Relates to GearConnect (m365) labels Apr 29, 2025
@jacdavi jacdavi merged commit 6daeb66 into main May 1, 2025
2 checks passed
@jacdavi jacdavi deleted the tagging branch May 2, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gearconnect Relates to GearConnect (m365) improvement This issue or pull request will add new or improve existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant