Skip to content

feat(m365): support secondary app for handling both Commercial/GCC High with single instance#14

Merged
jacdavi merged 4 commits intomainfrom
dual_apps
Jun 12, 2025
Merged

feat(m365): support secondary app for handling both Commercial/GCC High with single instance#14
jacdavi merged 4 commits intomainfrom
dual_apps

Conversation

@jacdavi
Copy link
Copy Markdown
Collaborator

@jacdavi jacdavi commented Jun 11, 2025

🗣 Description

  • Adds variables and container support for a secondary application ID.
  • Updates docs for variables
  • Changes REPORT_SAS variable to be null if not set

💭 Motivation and context

This change allows a secondary app to be created manually and is intended to allow one instance of ScubaConnect to handle tenants in both Commercial/GCC and GCC High.
For example, if ScubaConnect is hosted in GCC, an app can be manually made in GCC High and tied in so that the single ScubaConnect instance can run on tenants in any environment.

🧪 Testing

Created second app in GCC. Verified this application was used when environment_to_use was set to commercial and that the primary app was used when the variable was changed to gcchigh

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@jacdavi jacdavi requested a review from eagbaya June 12, 2025 00:30
@jacdavi jacdavi merged commit 4b4c379 into main Jun 12, 2025
7 checks passed
@jacdavi jacdavi deleted the dual_apps branch September 29, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants