feat(m365): Support Shared Access Signatures for Cross-Tenant Reporting#13
Merged
feat(m365): Support Shared Access Signatures for Cross-Tenant Reporting#13
Conversation
jacdavi
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Introduces a new optional Terraform variable
output_storage_container_sasto pass in a Shared Access Signature (SAS) token. When set, the SAS token will be used to authenticate to the output storage container when writing ScubaGear results. This is intended to be used whenoutput_storage_container_urlis set to a storage container in an external tenant.💭 Motivation and context
This provides additional flexibility when the ScubaConnect deployment and the output storage container are in different tenants. Authentication to the storage container currently relies on RBAC. This is automatically configured if Terraform deploys the storage container as part of ScubaConnect, but otherwise the owner of the storage container must grant access to the ScubaConnect service principal (requiring multi-tenant app consent). SAS tokens provide a less cumbersome and more tightly-scoped method to grant this access.
🧪 Testing
✅ Pre-approval checklist
✅ Post-merge checklist