Skip to content

feat(m365): Support Shared Access Signatures for Cross-Tenant Reporting#13

Merged
jacdavi merged 2 commits intomainfrom
remote_sas
Jun 2, 2025
Merged

feat(m365): Support Shared Access Signatures for Cross-Tenant Reporting#13
jacdavi merged 2 commits intomainfrom
remote_sas

Conversation

@eagbaya
Copy link
Copy Markdown
Collaborator

@eagbaya eagbaya commented Jun 2, 2025

🗣 Description

Introduces a new optional Terraform variable output_storage_container_sas to pass in a Shared Access Signature (SAS) token. When set, the SAS token will be used to authenticate to the output storage container when writing ScubaGear results. This is intended to be used when output_storage_container_url is set to a storage container in an external tenant.

💭 Motivation and context

This provides additional flexibility when the ScubaConnect deployment and the output storage container are in different tenants. Authentication to the storage container currently relies on RBAC. This is automatically configured if Terraform deploys the storage container as part of ScubaConnect, but otherwise the owner of the storage container must grant access to the ScubaConnect service principal (requiring multi-tenant app consent). SAS tokens provide a less cumbersome and more tightly-scoped method to grant this access.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@eagbaya eagbaya requested a review from jacdavi June 2, 2025 15:26
@jacdavi jacdavi merged commit 78b37ba into main Jun 2, 2025
7 checks passed
@jacdavi jacdavi deleted the remote_sas branch March 30, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants