Merged
Conversation
Closed
9555149 to
977ea2e
Compare
977ea2e to
9b0d5cc
Compare
The IP type was changed in hasql-1.8. Rather than forcing a breaking change, we export instances for both the old and new types. Resolves #341
9b0d5cc to
bc057ab
Compare
Contributor
Author
|
This should be ready for review now. I'm not sure if/how I should run ch-hs-import on these. I've vendored the logic for parsing IP addresses and made it so we support both the old and new IP package |
ocharles
approved these changes
Oct 9, 2024
Contributor
ocharles
left a comment
There was a problem hiding this comment.
LGTM, thanks! We should cut a release soon I think!
Contributor
Author
Sounds good! We should see if #331 is ready soon as well, since I think we use that internally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.