Introduce QualifiedName (fixes #228)#257
Merged
shane-circuithub merged 1 commit intomasterfrom Jul 11, 2023
Merged
Conversation
daa9b71 to
01b7e9d
Compare
ocharles
reviewed
Jul 8, 2023
ocharles
reviewed
Jul 8, 2023
5853189 to
c0e44bd
Compare
This adds a new type `QualifiedName` for named PostgreSQL objects (tables, views, functions and sequences) that can optionally be qualified by a schema. Previously only `TableSchema` could be qualified in this way. `QualifiedName` has an `IsString` instance so the common case (where the schema is `Nothing`) doesn't have to care about schemas (if `OverloadedStrings` is enabled). This also refactors `TableSchema` to use `QualifiedName` for its `name` field and drops its `schema` field. Thanks to @elldritch for the bug report and the inspiration.
c0e44bd to
e65d852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new type
QualifiedNamefor named PostgreSQL objects (tables, views, functions and sequences) that can optionally be qualified by a schema. Previously onlyTableSchemacould be qualified in this way.QualifiedNamehas anIsStringinstance so the common case (where the schema isNothing) doesn't have to care about schemas (ifOverloadedStringsis enabled).This also refactors
TableSchemato useQualifiedNamefor itsnamefield and drops itsschemafield.Thanks to @elldritch for the bug report and the inspiration.