Conversation
|
This looks good to me. I didn't know Postgres natively supported IP address types, but it makes sense to map them to the same type that |
|
Yep, that sounds good to me. @JonathanLorimer if you could change that lower bound, we'll get this merged. Thanks for your contribution! |
You should be able to |
unfortunately I get this when I run but I just did |
bdd9e58 to
9d72e86
Compare
|
@shane-circuithub or @ocharles can you approve the workflow? Tests are passing locally. |
This PR adds a DBType instance for
NetAddr IP, which is the default type that hasql uses for the postgresinettype. In the future I would also like to add support forSockAddrfrom thenetworkpackage.I'm a new committer and would appreciate any feedback, especially nitpicks and stylistic comments.
As a side note, I was wondering if you have a public nix cache. I am trying to set up my dev environment to test, but haskell.nix is trying to rebuild the world!