Use less Opaleye internals in aggregation#204
Merged
shane-circuithub merged 2 commits intocircuithub:masterfrom Nov 30, 2022
Merged
Use less Opaleye internals in aggregation#204shane-circuithub merged 2 commits intocircuithub:masterfrom
shane-circuithub merged 2 commits intocircuithub:masterfrom
Conversation
Contributor
Author
|
Hey folks, any thoughts on this? This would allow me to rearrange the Opaleye aggregate internals, which are in need of clarification. |
Contributor
|
@shane-circuithub Could you take a look at this? |
Contributor
|
I'm generally in favour of this. I know we currently don't use the |
Contributor
Author
|
Are you looking for |
Contributor
|
Yep, that looks like what I mean. In that case I don't see any downside to this. |
Contributor
|
Thanks @shane-circuithub! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would it be OK to do this, to depend on less Opaleye internals?