Use Opaleye adaptors#190
Merged
shane-circuithub merged 8 commits intocircuithub:masterfrom Aug 16, 2022
Merged
Conversation
287fa6c to
e86fbb0
Compare
e86fbb0 to
93d47fe
Compare
Contributor
Author
|
I intend to merge the above-mentioned change to |
93d47fe to
a4c3ddc
Compare
Contributor
|
Sorry for the silence @tomjaguarpaw - been off a bit recently but I'll try and take a look soon 👍 |
Contributor
|
Update: I want to get #194 in so CI can build this. Not sure why that's being fiddly, but that's the blocker atm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of my ongoing quest to reduce the amount of Opaleye internals that Rel8 depends on.
htraversePseems generally useful and worth including regardless, if you want Rel8 to play well with theProductProfunctorsecosystem.htraversePTypeisTable-specific. I'm not sure which module it should go in.Important note: I'm about to land a fairly big refactoring to
Opaleye.Internal.Values(tomjaguarpaw/haskell-opaleye@a7384fd) which will break Rel8masterbut is compatible with Rel8 post this PR.