Rename div and mod to quot and rem and introduce proper div and mod#155
Merged
shane-circuithub merged 2 commits intomasterfrom Jan 26, 2022
Merged
Rename div and mod to quot and rem and introduce proper div and mod#155shane-circuithub merged 2 commits intomasterfrom
shane-circuithub merged 2 commits intomasterfrom
Conversation
66dff7a to
b3beac1
Compare
The functions in `Rel8.Expr.Num` that were called `div` and `mod` actually behaved like the Haskell functions `quot` and `rem` on negative values.
b3beac1 to
5f9e608
Compare
ocharles
approved these changes
Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions in
Rel8.Expr.Numthat were calleddivandmodactually behaved like the Haskell functionsquotandremon negative values.