Conversation
|
@armanbilge Could this PR be made against series/0.14 branch in a bin-compat way? We'd probably want to release an 0.14 scala-native release if possible. |
|
Yes, absolutely. We definitely want this in an 0.14 release. I didn't change any sources so there should be no bincompat issues. |
|
Test failure is not specific to Scala Native, I was able to replicate it on the JVM. I believe @isomarcte recently revised this suite? |
|
This time a JVM failure ... |
|
Amazing, thanks! Just a minor nit: you pointed to my WIP PR and not the underlying issue. Probably best to say that this PR supersedes that PR instead of "closing" it, or say "close" and point to the underlying issue (or both). |
This was intentional. GitHub doesn't recognize the term "supersedes" last I checked, but it does recognize "close" to automatically close your PR when this one merges. although it seems that Darren already closed it :) I'll update to point to the original issue, but that one is rather old and already closed as well! |
I was sure I fixed that... |
|
On the 0.14.x branch? I'm afraid I've lost track between the 0.14, 0.15, and main branches. |
|
It might only be on 0.15. |
|
Great work! Thanks a bunch to all involved! I'm waiting for a milestone release with impatience to add Scala Native support for the circe booster too. |
@armanbilge |
|
Thanks, that helps clarify things! Let me know if I can help with a new 0.14.x release :) |
|
Thank you, Everyone! Just released a new version of the circe booster with Scala Native support. |
Closes #1929. See also #1077.