Skip to content

Scala Native#2017

Merged
zmccoy merged 62 commits intocirce:series/0.14.xfrom
armanbilge:feature/native
Sep 7, 2022
Merged

Scala Native#2017
zmccoy merged 62 commits intocirce:series/0.14.xfrom
armanbilge:feature/native

Conversation

@armanbilge
Copy link
Contributor

@armanbilge armanbilge commented Sep 1, 2022

Closes #1929. See also #1077.

zarthross
zarthross previously approved these changes Sep 6, 2022
@zarthross
Copy link
Member

@armanbilge Could this PR be made against series/0.14 branch in a bin-compat way? We'd probably want to release an 0.14 scala-native release if possible.

@armanbilge
Copy link
Contributor Author

Yes, absolutely. We definitely want this in an 0.14 release. I didn't change any sources so there should be no bincompat issues.

@armanbilge armanbilge changed the base branch from main to series/0.14.x September 6, 2022 22:28
@armanbilge armanbilge dismissed zarthross’s stale review September 6, 2022 22:28

The base branch was changed.

@armanbilge armanbilge closed this Sep 6, 2022
@armanbilge armanbilge reopened this Sep 6, 2022
@armanbilge
Copy link
Contributor Author

Test failure is not specific to Scala Native, I was able to replicate it on the JVM. I believe @isomarcte recently revised this suite?

==> X io.circe.pointer.literal.PointerInterpolatorSuite.The pointer string interpolater should work with arbitrary interpolated strings  0.246s munit.FailException: /workspace/circe/modules/pointer-literal/src/test/scala/io/circe/pointer/literal/PointerInterpolatorSuite.scala:49
48:
49:  property("The pointer string interpolater should work with arbitrary interpolated strings") {
50:    Prop.forAll(ScalaCheckInstances.genPointerReferenceString) { (v: String) =>

Failing seed: qzbVz6jmqdOrJ6jdDd_E9p990OQHEWa1EeruSk3VXuF=
You can reproduce this failure by adding the following override to your suite:

  override val scalaCheckInitialSeed = "qzbVz6jmqdOrJ6jdDd_E9p990OQHEWa1EeruSk3VXuF="

Falsified after 72 passed tests.
> Labels of failing property: 
Expected Right(/foo/~0/bar) but got Left(io.circe.pointer.PointerSyntaxError: Syntax error at 5; expected: token character)
> ARG_0: "~"
> ARG_0_ORIGINAL: "뙪쀿냡㙼㴗Ꝙ阎⿖鶕埝覃廦羄剘竀⅁迠䵿異謋⥿튏╰厳셖ᬵ┺翌话ˑ쇴椅鳟튯캧饞朗㢗濓ደ盷봙醛莪ﵴ넼孅瘭ޢ깬ཪ㑹쐉鉚鶷삀葬ퟌ讛狾噙~1䒤訢薸쇝ᄇ톧펥"

@armanbilge armanbilge closed this Sep 6, 2022
@armanbilge armanbilge reopened this Sep 6, 2022
@armanbilge
Copy link
Contributor Author

This time a JVM failure ...

==> X io.circe.pointer.literal.PointerInterpolatorSuite.The pointer string interpolater should work with arbitrary interpolated strings  0.427s munit.FailException: /home/runner/work/circe/circe/modules/pointer-literal/src/test/scala/io/circe/pointer/literal/PointerInterpolatorSuite.scala:47
46:
47:  property("The pointer string interpolater should work with arbitrary interpolated strings") {
48:    Prop.forAll(ScalaCheckInstances.genPointerReferenceString) { (v: String) =>

Failing seed: dEYU1agSRFmo29QBq3dMD5Z7J7h7UDHzuNpeGVbviQO=
You can reproduce this failure by adding the following override to your suite:

  override val scalaCheckInitialSeed = "dEYU1agSRFmo29QBq3dMD5Z7J7h7UDHzuNpeGVbviQO="

@armanbilge armanbilge closed this Sep 6, 2022
@armanbilge armanbilge reopened this Sep 6, 2022
@adampauls
Copy link

Amazing, thanks! Just a minor nit: you pointed to my WIP PR and not the underlying issue. Probably best to say that this PR supersedes that PR instead of "closing" it, or say "close" and point to the underlying issue (or both).

@armanbilge
Copy link
Contributor Author

Probably best to say that this PR supersedes that PR instead of "closing" it, or say "close" and point to the underlying issue (or both).

This was intentional. GitHub doesn't recognize the term "supersedes" last I checked, but it does recognize "close" to automatically close your PR when this one merges. although it seems that Darren already closed it :)

I'll update to point to the original issue, but that one is rather old and already closed as well!

@armanbilge armanbilge mentioned this pull request Sep 7, 2022
@isomarcte
Copy link
Contributor

Test failure is not specific to Scala Native, I was able to replicate it on the JVM. I believe @isomarcte recently revised this suite?

I was sure I fixed that...

@armanbilge
Copy link
Contributor Author

On the 0.14.x branch? I'm afraid I've lost track between the 0.14, 0.15, and main branches.

@isomarcte
Copy link
Contributor

It might only be on 0.15.

@zmccoy zmccoy merged commit f15be0d into circe:series/0.14.x Sep 7, 2022
@plokhotnyuk
Copy link
Contributor

Great work! Thanks a bunch to all involved!

I'm waiting for a milestone release with impatience to add Scala Native support for the circe booster too.

@zarthross
Copy link
Member

On the 0.14.x branch? I'm afraid I've lost track between the 0.14, 0.15, and main branches.

@armanbilge series/0.14.x is now the default branch, main is no more, and series/0.15.x is the home of new stuff no compatible with series/0.14. Hopefully this helps.

@armanbilge
Copy link
Contributor Author

Thanks, that helps clarify things! Let me know if I can help with a new 0.14.x release :)

@plokhotnyuk
Copy link
Contributor

Thank you, Everyone!

Just released a new version of the circe booster with Scala Native support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants