Conversation
|
|
||
| def Scala3 = "3.1.0" | ||
| ThisBuild / tlBaseVersion := "0.14" | ||
| ThisBuild / tlCiReleaseTags := false |
There was a problem hiding this comment.
This disables CI release, but say the word (and configure the secrets) and I'll switch it on :)
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 74 74
Lines 2554 2554
Branches 136 120 -16
=======================================
Hits 2197 2197
Misses 357 357
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@zarthross we cannot update to sbt-git 2.0.0 here, because of the sbt-microsites plugin. As proposed in #1958 (comment) switching to sbt-typelevel-site would solve that issue. |
|
@zarthross polite bump on this :) build overhauls tend to have large surface area for conflict. |
|
I think it looks fine. I'll have @zmccoy look over it too before we merge it in. Thanks for taking this on @armanbilge, and sorry for the late review. @armanbilge If you still feel like switching this over to sbt-typelevel-site i would welcome the change. |
|
No problem, thanks for reviewing! Sure, I'll work on the site in a follow-up PR :) |
zmccoy
left a comment
There was a problem hiding this comment.
This looks great! Sorry this took a bit for some attention to get to it.
Thank you for doing this!
As discussed in #1958 (comment).
Currently the website build is broken for unclear reasons (besides it's behind a major version in mdoc). I'm loathe to sink time into it if it's going to be replaced by the sbt-typelevel-site plugin.Edit: maybe I fixed it ...