Skip to content

Support output tuple for 802.1Q#544

Merged
smagnani96 merged 1 commit intocilium:mainfrom
chenhengqi:8021q-tuple
Apr 17, 2025
Merged

Support output tuple for 802.1Q#544
smagnani96 merged 1 commit intocilium:mainfrom
chenhengqi:8021q-tuple

Conversation

@chenhengqi
Copy link
Contributor

This has been done in set_xdp_tuple(). Before this change, we have:

0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                vlan_gro_receive :0->:0()
0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                inet_gro_receive :0->:0()
0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_defer_rx_timestamp :0->:0()
0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                get_rps_cpu :0->:0()
0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __skb_get_hash :0->:0()
0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                enqueue_to_backlog :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __netif_receive_skb :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __netif_receive_skb_one_core :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_vlan_untag :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_pull_rcsum :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tc_run :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tcf_classify :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_do_redirect :0->:0()
0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         __bpf_redirect :0->:0()

With this change, we have:

0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         vlan_gro_receive :0->:0()
0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         inet_gro_receive :0->:0()
0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_defer_rx_timestamp :0->:0()
0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         get_rps_cpu :0->:0()
0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __skb_get_hash :0->:0()
0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         enqueue_to_backlog :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __netif_receive_skb :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __netif_receive_skb_one_core :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_vlan_untag :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_pull_rcsum :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tc_run :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tcf_classify :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_do_redirect :0->:0()
0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         __bpf_redirect :0->:0()

This has been done in set_xdp_tuple(). Before this change,
we have:

    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                vlan_gro_receive :0->:0()
    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                inet_gro_receive :0->:0()
    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_defer_rx_timestamp :0->:0()
    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                get_rps_cpu :0->:0()
    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __skb_get_hash :0->:0()
    0xffff8883ab72f800 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                enqueue_to_backlog :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __netif_receive_skb :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                __netif_receive_skb_one_core :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_vlan_untag :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    :0->:0()                                skb_pull_rcsum :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tc_run :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tcf_classify :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_do_redirect :0->:0()
    0xffff8883ab72f800 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         __bpf_redirect :0->:0()

With this change, we have:

    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         vlan_gro_receive :0->:0()
    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         inet_gro_receive :0->:0()
    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_defer_rx_timestamp :0->:0()
    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         get_rps_cpu :0->:0()
    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __skb_get_hash :0->:0()
    0xffff88824f1ac700 6   <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         enqueue_to_backlog :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __netif_receive_skb :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         __netif_receive_skb_one_core :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_vlan_untag :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x8100 1500  88    10.0.32.12:0->10.0.32.7:0(icmp)         skb_pull_rcsum :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tc_run :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  84    10.0.32.12:0->10.0.32.7:0(icmp)         tcf_classify :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_ensure_writable :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         skb_do_redirect :0->:0()
    0xffff88824f1ac700 14  <empty>:0        4026531840 0             eth1:3      0x0800 1500  98    10.0.32.12:0->10.0.32.7:0(icmp)         __bpf_redirect :0->:0()

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
@chenhengqi chenhengqi requested a review from a team as a code owner April 17, 2025 05:19
@chenhengqi chenhengqi requested review from smagnani96 and removed request for a team April 17, 2025 05:19
@smagnani96 smagnani96 merged commit 927bf25 into cilium:main Apr 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants