Support output tuple for 802.1Q#544
Merged
smagnani96 merged 1 commit intocilium:mainfrom Apr 17, 2025
Merged
Conversation
This has been done in set_xdp_tuple(). Before this change,
we have:
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() vlan_gro_receive :0->:0()
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() inet_gro_receive :0->:0()
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() skb_defer_rx_timestamp :0->:0()
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() get_rps_cpu :0->:0()
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() __skb_get_hash :0->:0()
0xffff8883ab72f800 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() enqueue_to_backlog :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() __netif_receive_skb :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() __netif_receive_skb_one_core :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() skb_vlan_untag :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 :0->:0() skb_pull_rcsum :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 84 10.0.32.12:0->10.0.32.7:0(icmp) tc_run :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 84 10.0.32.12:0->10.0.32.7:0(icmp) tcf_classify :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_ensure_writable :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_ensure_writable :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_do_redirect :0->:0()
0xffff8883ab72f800 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) __bpf_redirect :0->:0()
With this change, we have:
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) vlan_gro_receive :0->:0()
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) inet_gro_receive :0->:0()
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) skb_defer_rx_timestamp :0->:0()
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) get_rps_cpu :0->:0()
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) __skb_get_hash :0->:0()
0xffff88824f1ac700 6 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) enqueue_to_backlog :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) __netif_receive_skb :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) __netif_receive_skb_one_core :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) skb_vlan_untag :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x8100 1500 88 10.0.32.12:0->10.0.32.7:0(icmp) skb_pull_rcsum :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 84 10.0.32.12:0->10.0.32.7:0(icmp) tc_run :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 84 10.0.32.12:0->10.0.32.7:0(icmp) tcf_classify :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_ensure_writable :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_ensure_writable :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) skb_do_redirect :0->:0()
0xffff88824f1ac700 14 <empty>:0 4026531840 0 eth1:3 0x0800 1500 98 10.0.32.12:0->10.0.32.7:0(icmp) __bpf_redirect :0->:0()
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
smagnani96
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been done in set_xdp_tuple(). Before this change, we have:
With this change, we have: