Support --filter-mark mark/[/mask]#471
Merged
jschwinger233 merged 1 commit intocilium:mainfrom Dec 19, 2024
Merged
Conversation
Contributor
Author
|
cc @jschwinger233 Left this as a draft for now as I didn't have good means to test the change. |
jschwinger233
requested changes
Dec 18, 2024
Member
jschwinger233
left a comment
There was a problem hiding this comment.
I believe we should filter skbs from kernel space by revising kprobe/kprobe_pwru.c?
Contributor
Author
|
Not sure I follow. I didn't change the filtering, I just made sure a mask can be passed with the --filter-mark flag, and if it is then we apply it. What would you move to kernel space? Applying the mask? |
This commit allows specifying a mask when filtering for packet marks with pwru. Fixes: cilium#296 Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
08c3102 to
819c4d8
Compare
jschwinger233
approved these changes
Dec 19, 2024
Asphaltt
reviewed
Dec 19, 2024
Contributor
Author
|
Marking as ready for review, as it should be good to be merged. |
jschwinger233
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows specifying a mask when filtering for packets marks with pwru.
Fixes: #296