Implement --filter-track-skb-by-stackid#354
Merged
brb merged 1 commit intocilium:mainfrom Apr 19, 2024
Merged
Conversation
7cf8876 to
61193cf
Compare
Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
61193cf to
cb6ea35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--filter-track-skb-by-stackidso we can track traffic even the skb is kfreed and re-built, which frequently happens when traffic is going through bridge. This is more powerful than--filter-track-skbon the scenario of encryption + encapsulation.This PR also paves the way for "tailcall tracing" which relies on stack unwinding. I find it valuable to make stack unwinding a general feature so this is it.
An skb can have different stacks during its lifetime, this PR tries to handle it carefully by comparing
old_stackidwithstackidand updating the bpf map in time.Signed-off-by: Zhichuan Liang gray.liang@isovalent.com