Accelerate attaching/detaching kprobes#277
Merged
brb merged 3 commits intocilium:mainfrom Feb 26, 2024
Merged
Conversation
5e0a536 to
7db659a
Compare
Contributor
Author
|
Hi @jschwinger233 , could you give me a hand to check why it failed to run --filter-ifname case? |
Member
|
@Asphaltt Thanks for the PR! Could you rebase your PR against the latest |
3c02b29 to
299fc47
Compare
b388da2 to
dc1371d
Compare
Contributor
Author
|
Hi, brb, I'll continue on this PR after my PTO. Thanks. |
Member
|
Hey @Asphaltt , sorry, I was lagging w/ reviews (ETOOBUSYATWORK). The bpf-next CI failure should be unrelated to your changes, as I am seeing the same failure on other branches. So, something got broken in the bpf-next kernel. |
Member
|
bpf-next failure - #284. |
dc1371d to
e06b603
Compare
Member
|
bpf-next-main failure looks like a lvh problem, I hit the same at another project. Using the latest version like |
Member
|
Yep, bpf-next is failing due to #284 (I haven't found time to fix it yet 😞 )
Interesting. Could you |
Member
|
@Asphaltt Could you rebase? |
Member
|
@Asphaltt 👋 Could you rebase? |
Contributor
Author
|
I will rebase it later, thx. |
e06b603 to
0c12b8f
Compare
brb
requested changes
Feb 22, 2024
In order to accelerate attaching/detaching kprobes, do attach/detach
kprobes concurrently. By concurrent way, it is a little faster than
original way.
On my 6 CPU cores VM,
run by concurrent way:
```
2023/10/25 14:16:03 Attaching kprobes (via kprobe)...
1462 / 1462 [----------------------------------------------------------------------------------------------------] 100.00% 342 p/s
2023/10/25 14:16:07 Attached (ignored 0)
2023/10/25 14:16:07 Listening for events..
SKB CPU PROCESS FUNC
^C2023/10/25 14:16:08 Received signal, exiting program..
2023/10/25 14:16:08 Detaching kprobes...
1462 / 1462 [-----------------------------------------------------------------------------------------------------] 100.00% 35 p/s
```
run by original way:
```
2023/10/25 14:17:27 Attaching kprobes (via kprobe)...
1462 / 1462 [----------------------------------------------------------------------------------------------------] 100.00% 282 p/s
2023/10/25 14:17:32 Attached (ignored 0)
2023/10/25 14:17:32 Listening for events..
SKB CPU PROCESS FUNC
^C2023/10/25 14:17:33 Received signal, exiting program..
2023/10/25 14:17:33 Detaching kprobes...
1462 / 1462 [-----------------------------------------------------------------------------------------------------] 100.00% 21 p/s
```
Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Flush output file before closing it. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
b7c00e3 to
4ebecc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #274
In order to accelerate attaching/detaching kprobes, do attach/detach kprobes concurrently. By concurrent way, it's a little faster than original way.
On my 6 CPU cores VM,
run by concurrent way:
run by original way: