Conversation
f0e635e to
fe2ba33
Compare
gandro
requested changes
Apr 6, 2020
Member
gandro
left a comment
There was a problem hiding this comment.
Looks good! Just one minor request with regards to forward-compatibility.
This gRPC service will be implemented by embedded Hubble and be used for peer discovery by the Hubble proxy server. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
fe2ba33 to
3bc6f82
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This service is required for peer discovery in the context of the multi-node feature. It will be implemented by embedded Hubble using Cilium's node manager and be used by Hubble proxy to discover Hubble peers and get notified of changes.
I've implemented the gRPC service locally to see if it fits the needs and I can confirm that it does.
It initially consisted of 2 rpc calls but after a discussion with @gandro, we concluded that trimming down to a single rpc call would not only simplify implementation and usage but would also prevent a class of bugs where races could occur (between a call to list and notify for example) leading a client to eventually miss peer change notifications.
Ref: #89