btf: don't try to load strings when file is empty#1837
Merged
lmb merged 1 commit intocilium:mainfrom Jul 30, 2025
Merged
Conversation
Member
|
This seems to be a duplicate / alternative PR for https://github.com/cilium/ebpf/pull/1828/files |
Contributor
Author
That one returns a non-empty list while the file is empty. IMHO, this is a better solution. |
Fixes: cilium#1818 Signed-off-by: therealak12 <ak12hastam@gmail.com> Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Contributor
|
Thanks for adding the test, that was useful. Rebased this on main and changed it to use the approach where newStringTable deals with emptiness. |
lmb
approved these changes
Jul 30, 2025
Contributor
Author
|
I assumed introducing an outer check on |
Contributor
|
There are no system calls performed, and function calls are not really measurable at this level. Maybe you mean because the original code did some io.Read? That is gone now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this PR to address issue#1818.
In my experience, the problem has been occurring since version v0.19.0 (it does not appear in v0.18.0), specifically for the
aesni_intelkernel module. The error encountered is:I've checked
stat /sys/kernel/btf/aesni_intel. It shows 24 bytes, which is for the BTF header, but it has no content.