Skip to content

Enhance Makefile for Cilium website development and Docker workflow#772

Merged
xmulligan merged 3 commits intocilium:mainfrom
yashisrani:add/dockerfile
Sep 22, 2025
Merged

Enhance Makefile for Cilium website development and Docker workflow#772
xmulligan merged 3 commits intocilium:mainfrom
yashisrani:add/dockerfile

Conversation

@yashisrani
Copy link
Copy Markdown
Contributor

@yashisrani yashisrani commented Sep 16, 2025 •
edited
Loading

fix: #773

Description:

  • This PR improves the Makefile for the Cilium website by:

    • Adding an env target to safely copy .env.example to .env.
    • Introducing start (lightweight dev) and start-full (full dev) targets.
    • Adding Docker targets: docker-build, docker-run, docker-run-dev, and docker-shell.
    • Including linting, formatting, and reinstall targets for easier local setup.

  • These changes simplify contributor setup, reduce CPU load during development, and standardize Docker workflows.

How to use:

make env           # create .env if missing
make start         # start lightweight dev server
make start-full    # start full dev server (images processed)
make build         # production build
make serve         # serve production build locally
make docker-build  # build Docker image
make docker-run    # run production Docker container
make docker-run-dev # run dev environment in Docker

@actions-user
chore: improve Makefile with env setup, Docker, and dev targets
f5c553c 
Signed-off-by: GitHub Action <action@github.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 16, 2025

👷 Deploy Preview for cilium processing.

Name Link
🔨 Latest commit f5c553c
🔍 Latest deploy log https://app.netlify.com/projects/cilium/deploys/68c99ba2b5046c0007609eef

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 16, 2025 •
edited
Loading

✅ Deploy Preview for cilium ready!

Name Link
🔨 Latest commit afa4b97
🔍 Latest deploy log https://app.netlify.com/projects/cilium/deploys/68caceaf63998d0008f58e85
😎 Deploy Preview https://deploy-preview-772--cilium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xmulligan xmulligan requested a review from paularah September 17, 2025 05:30
@paularah
Copy link
Copy Markdown
Contributor

paularah commented Sep 17, 2025

@yashisrani You should add a corresponding note in the README on how to use the makefile.

@actions-user
docs: add Makefile usage commands to README
4771c71 
Signed-off-by: GitHub Action <action@github.com>
@paularah
Copy link
Copy Markdown
Contributor

paularah commented Sep 17, 2025

in the getting started section of README, add a note that says something along the lines of: "There's a makefile with all the dev commands, you can set the project using make dev, make env & make start.

@yashisrani
Copy link
Copy Markdown
Contributor Author

yashisrani commented Sep 17, 2025

@paularah Do you want me to also remove the raw npm commands (to avoid duplication), or should we keep both for flexibility?

@paularah
Copy link
Copy Markdown
Contributor

paularah commented Sep 17, 2025

Keep both. I'll add a small sidenote for the dev commands.

@yashisrani
fix: updated readme file
afa4b97 
Signed-off-by: Yash Israni <yashisrani52@gmail.com>
@paularah
Copy link
Copy Markdown
Contributor

paularah commented Sep 18, 2025

Thanks for the PR!

@yashisrani yashisrani requested a review from paularah September 18, 2025 12:16
@xmulligan xmulligan merged commit 6267010 into cilium:main Sep 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paularah paularah paularah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Makefile for Cilium website development and Docker workflow

4 participants

@yashisrani @paularah @xmulligan @actions-user