Skip to content

1.6 CI fixes#8779

Merged
tgraf merged 6 commits intomasterfrom
pr/tgraf/ci-fixes
Aug 5, 2019
Merged

1.6 CI fixes#8779
tgraf merged 6 commits intomasterfrom
pr/tgraf/ci-fixes

Conversation

@tgraf
Copy link
Copy Markdown
Contributor

@tgraf tgraf commented Aug 5, 2019 •
edited
Loading

Various fixes to address 1.6 CI stability

Fixes: #8775

This change is Reviewable

tgraf added 3 commits August 5, 2019 14:41
@tgraf
test: Do not deploy etcd-operator in BeforeAll()
8778923 
This was a no-op as the manifests have been removed but no error was reported
so this failed silently without any effect.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Use resource names to delete etcd-operator
c3b1e07 
As the manifests are no longer available, use resource names to remove the
etcd-operator.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Delete CoreDNS deployment after upgrade/downgrade test
b3ac3a2 
The call to CiliumInstall() will deploy CoreDNS again but then not remove it.
Remove it properly at the end of the test.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added the wip label Aug 5, 2019
@tgraf tgraf requested a review from a team as a code owner August 5, 2019 13:15
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Aug 5, 2019 •
edited
Loading

test-me-please

EDIT: green build

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 44.148% when pulling 1d7c08c on pr/tgraf/ci-fixes into 5c04020 on master.

@tgraf tgraf force-pushed the pr/tgraf/ci-fixes branch from 18f3c77 to 7640510 Compare August 5, 2019 15:26
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Aug 5, 2019

Running a 2nd CI run as this can potentially resolves #8780, #8778, #8777, #8776

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Aug 5, 2019 •
edited
Loading

test-me-please

The following tests failed:

  1. Suite-k8s-1.10.K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

    • Connectivity health check did not succeed in time

  2. Suite-k8s-1.15.K8sPolicyTest Basic Test Validate to-entities policies Validate toEntities

    • Connection timed out in the middle of google.com responding. Looks like a flake.

  3. Suite-k8s-1.15.K8sServicesTest Checks service across nodes with L7 policy Tests NodePort with L7 Policy

@tgraf tgraf added area/CI Continuous Integration testing issue or flake pending-review and removed wip labels Aug 5, 2019
@tgraf tgraf added this to the 1.6.0 milestone Aug 5, 2019
ianvernon
ianvernon reviewed Aug 5, 2019
View reviewed changes
Comment thread test/helpers/kubectl.go Outdated
Comment thread test/helpers/kubectl.go Outdated
Comment thread test/helpers/kubectl.go Outdated
Copy link
Copy Markdown
Member

@ianvernon ianvernon Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we generate different resources in K8s based off of the Helm options? Most of these appear to be options provided to the DaemonSet / ConfigMap - can you elaborate on what K8s resources are different depending upon the Helm options?

Copy link
Copy Markdown
Contributor Author

@tgraf tgraf Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Inclusion of etcd-operator and related ClusterRole, ClusterRoleBinding and ServiceAccount.

tgraf added 3 commits August 5, 2019 20:56
@tgraf
test: Provide symmetric uninstall method
624970d 
This allows to remove all Cilium resources based on the Helm template. Use it
for the upgrade/downgrade test to properly remove all remaining resources.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Do not re-deploy CoreDNS after all upgrade/downgrade tests
493c1e3 
CoreDNS is installed in the tests themselves using the right version. Other
tests do not depend on CoreDNS running.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Remove unused GetK8sDescriptor
1d7c08c 
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/ci-fixes branch from 7640510 to 1d7c08c Compare August 5, 2019 19:02
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Aug 5, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented Aug 5, 2019

@nebril This seems to fix #8775 and maybe also #8777

@tgraf tgraf merged commit c4d6257 into master Aug 5, 2019
@tgraf tgraf deleted the pr/tgraf/ci-fixes branch August 5, 2019 21:23
@jrfastab jrfastab mentioned this pull request Aug 6, 2019
Merged
@ianvernon ianvernon mentioned this pull request Aug 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nebril nebril nebril approved these changes

+1 more reviewer

@ianvernon ianvernon ianvernon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

[v1.7] CI: K8sIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity

5 participants

@tgraf @coveralls @nebril @ianvernon @jrfastab