Closed
Conversation
The nexthop route was injected into the default table instead of the table specified. This code path was not used so far, this is a fix for a potential future usage. Fixes: fec5499 ("route: Fix route replacement logic for IPv6") Signed-off-by: Thomas Graf <thomas@cilium.io>
brb
approved these changes
Jun 17, 2019
vadorovsky
approved these changes
Jun 17, 2019
Contributor
Author
|
test-me-please |
aanm
approved these changes
Jun 17, 2019
Contributor
Author
|
@jrfastab I see that the IPsec code may depend on the old broken behavior. Is this intentional? |
Contributor
|
The encryption path was using the next hop rule to match the outer IP tunnel IP and route the packet to cilium_host to clear the mark fields (so it doesn't try to encrypt again) and to redirect to tunnel device if in tunnel mode. couple options either add a flag to keep the current behavior or probably a bit more clean set an explicit route in default table. |
Contributor
Author
|
Pulled in via #8322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for #8322 to be merged
The nexthop route was injected into the default table instead of the table
specified. This code path was not used so far, this is a fix for a potential
future usage.
Fixes: fec5499 ("route: Fix route replacement logic for IPv6")
This change is