Skip to content

pkg/ipam: protect map against concurrent access#8279

Merged
tgraf merged 1 commit intomasterfrom
pr/fix-ipam
Jun 12, 2019
Merged

pkg/ipam: protect map against concurrent access#8279
tgraf merged 1 commit intomasterfrom
pr/fix-ipam

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Jun 12, 2019

Fixes: 58579f1 ("ipam: Use Blacklist() to reserve IP in allocation range")
Signed-off-by: André Martins andre@cilium.io

Fixes #8278


This change is Reviewable

Fixes: 58579f1 ("ipam: Use Blacklist() to reserve IP in allocation range")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug This is a bug in the Cilium logic. pending-review labels Jun 12, 2019
@aanm aanm requested a review from a team as a code owner June 12, 2019 09:19
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 12, 2019

test-me-please

1 similar comment
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Jun 12, 2019

test-me-please

@aanm aanm added this to the 1.6.0 milestone Jun 12, 2019
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.003%) to 42.012% when pulling 7b5c54c on pr/fix-ipam into ab10bc5 on master.

Copy link
Copy Markdown
Contributor

@tgraf tgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@tgraf tgraf merged commit c966ef8 into master Jun 12, 2019
@tgraf tgraf deleted the pr/fix-ipam branch June 12, 2019 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug This is a bug in the Cilium logic.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cilium agent: fatal error: concurrent map writes

5 participants