Skip to content

test: replace guestbook test docker image#7955

Merged
ianvernon merged 1 commit intomasterfrom
pr/fix-guestbook-test
May 9, 2019
Merged

test: replace guestbook test docker image#7955
ianvernon merged 1 commit intomasterfrom
pr/fix-guestbook-test

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented May 8, 2019 •
edited by tgraf
Loading

The image docker.io/kubernetes/guestbook:v2 no longer exists so we need
to update the guestbook test to make usage of the new guestbook test
version.

Signed-off-by: André Martins andre@cilium.io

This change is Reviewable

@aanm aanm added pending-review area/CI Continuous Integration testing issue or flake labels May 8, 2019
@aanm aanm requested a review from a team as a code owner May 8, 2019 13:24
@aanm aanm force-pushed the pr/fix-guestbook-test branch from 0cfbc22 to 4dc9b6e Compare May 8, 2019 13:25
@aanm aanm changed the title test: fix guestbook test test: replace guestbook test docker image May 8, 2019
@aanm aanm added the area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label May 8, 2019
@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 8, 2019

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented May 8, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.007%) to 41.576% when pulling 110df4a on pr/fix-guestbook-test into e1101d0 on master.

@tgraf
Copy link
Copy Markdown
Contributor

tgraf commented May 8, 2019

@aanm Why does this need backports into all branches?

@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 8, 2019

@aanm Why does this need backports into all branches?

@tgraf the CI test will fail if the image is not in the local cache.

@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 8, 2019

test-missed-k8s

1 similar comment
@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 8, 2019

test-missed-k8s

ianvernon
ianvernon suggested changes May 8, 2019
View reviewed changes
Comment thread test/k8sT/manifests/guestbook_deployment.json Outdated
@aanm
test: replace guestbook test docker image
110df4a 
The image docker.io/kubernetes/guestbook:v2 no longer exists so we need
to update the guestbook test to make usage of the new guestbook test
version.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-guestbook-test branch from 4dc9b6e to 110df4a Compare May 8, 2019 18:13
@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 8, 2019

test-me-please

@aanm
Copy link
Copy Markdown
Member Author

aanm commented May 9, 2019

test-missed-k8s

@aanm aanm requested a review from ianvernon May 9, 2019 13:29
@ianvernon ianvernon merged commit ae9e4be into master May 9, 2019
@ianvernon ianvernon deleted the pr/fix-guestbook-test branch May 9, 2019 20:20
@nebril nebril mentioned this pull request May 14, 2019
Closed
This was referenced May 14, 2019
Merged
Closed
@nebril nebril mentioned this pull request May 14, 2019
Closed
This was referenced Jun 4, 2019
Merged
Merged
@pchaigno pchaigno mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ianvernon ianvernon ianvernon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake area/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aanm @coveralls @tgraf @ianvernon @joestringer @nebril