Skip to content

test: Add readiness probe to demo deployments#7903

Merged
ianvernon merged 1 commit intomasterfrom
pr/tgraf/ci-demo-readiness-probe
May 2, 2019
Merged

test: Add readiness probe to demo deployments#7903
ianvernon merged 1 commit intomasterfrom
pr/tgraf/ci-demo-readiness-probe

Conversation

@tgraf
Copy link
Copy Markdown
Contributor

@tgraf tgraf commented May 1, 2019 •
edited
Loading

The CI code was waiting for the pods to be marked as ready but there was no
readiness probe so it was possible for the connectivity to be checked before
the server pod was up and running properly.

Fixes: #7902

This change is Reviewable

@tgraf tgraf added pending-review area/CI Continuous Integration testing issue or flake labels May 1, 2019
@tgraf tgraf added this to the 1.6.0 milestone May 1, 2019
@tgraf tgraf requested a review from a team as a code owner May 1, 2019 13:10
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

test-me-please

@coveralls
Copy link
Copy Markdown

coveralls commented May 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 41.599% when pulling a6ae243 on pr/tgraf/ci-demo-readiness-probe into b2cf046 on master.

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

K8sServicesTest Checks ClusterIP Connectivity Checks service on same node flake was hit despite this. This will not fix #7902.

@tgraf tgraf force-pushed the pr/tgraf/ci-demo-readiness-probe branch from 93e8b86 to b1bb951 Compare May 1, 2019 15:14
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

I've noticed that WaitforPods() used in this example does not require a particular number of pods to be in ready state so it can also be 0.

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

Did not hit K8sServicesTest Checks ClusterIP Connectivity Checks service on same node 1/, trying again.

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

2/ succeeded

@tgraf
test: Add readiness probe to demo deployments
a6ae243 
The CI code was waiting for the pods to be marked as ready but there was no
readiness probe so it was possible for the connectivity to be checked before
the server pod was up and running properly.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/ci-demo-readiness-probe branch from 6af1dbc to 556e936 Compare May 1, 2019 22:25
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 1, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

Did not hit #7902 again, Re-adding fixes tag

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

Hit Suite-k8s-1.14.K8sIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity flake

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

Hit Istio tests failure again

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

VM image download timeout

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

Testing without 556e936 again

@tgraf tgraf force-pushed the pr/tgraf/ci-demo-readiness-probe branch from 556e936 to a6ae243 Compare May 2, 2019 13:20
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

1 similar comment
@tgraf
Copy link
Copy Markdown
Contributor Author

tgraf commented May 2, 2019

test-me-please

@ianvernon ianvernon merged commit ebc77ec into master May 2, 2019
@ianvernon ianvernon deleted the pr/tgraf/ci-demo-readiness-probe branch May 2, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanm aanm aanm approved these changes

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

[not a flake] K8sServicesTest Checks ClusterIP Connectivity Checks service on same node

4 participants

@tgraf @coveralls @aanm @ianvernon