pkg/endpoint: fix global k8sServerVer variable assignment#5926
Merged
Conversation
As the variable is being globally assigned for all endpoints, if one endpoints re-sets it to nil it can cause a nil pointer exception during a controller execution causing the cilium-agent to crash. Fixes: a8a81b3 ("pkg/endpoint: add UpdateStatus functionality for CEP") Signed-off-by: André Martins <andre@cilium.io>
Member
Author
|
test-me-please |
This was referenced Oct 17, 2018
ianvernon
approved these changes
Oct 17, 2018
tgraf
approved these changes
Oct 17, 2018
This was referenced Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the variable is being globally assigned for all endpoints, if one
endpoints re-sets it to nil it can cause a nil pointer exception during
a controller execution causing the cilium-agent to crash.
Fixes: a8a81b3 ("pkg/endpoint: add UpdateStatus functionality for CEP")
Signed-off-by: André Martins andre@cilium.io
Related with #5913
This change is