Skip to content

ci: add fail-fast false to ci image builds#45079

Merged
aanm merged 1 commit intomainfrom
pr/artyop/fail-fast-ci-build
Apr 1, 2026
Merged

ci: add fail-fast false to ci image builds#45079
aanm merged 1 commit intomainfrom
pr/artyop/fail-fast-ci-build

Conversation

@Artyop
Copy link
Copy Markdown
Contributor

@Artyop Artyop commented Mar 31, 2026

Sometimes CI image build has failures due to transient issues (e.g. network issues, cosign failures, rate limits, etc.). Github workflow strategy for matrix jobs uses fail-fast option to true per default, cancelling all jobs when one fails.

Allowing fail-fast false to the image CI build will permit to just retry the build of failed images instead of running the whole workflow again.

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2026
@Artyop Artyop added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Mar 31, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2026
@Artyop
Copy link
Copy Markdown
Contributor Author

Artyop commented Mar 31, 2026

/test

@Artyop Artyop marked this pull request as ready for review March 31, 2026 13:26
@Artyop Artyop requested review from a team as code owners March 31, 2026 13:26
@Artyop Artyop requested review from aanm and nbusseneau March 31, 2026 13:26
Copy link
Copy Markdown
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart.

@aanm aanm added needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Apr 1, 2026
@aanm aanm enabled auto-merge April 1, 2026 08:33
Sometimes CI image build has failures due to transient issues
(e.g. network issues, cosign failures, rate limits, etc.).
Github workflow strategy for matrix jobs uses fail-fast option to true
per default, cancelling all jobs when one fails.

Allowing fail-fast false to the image CI build will permit to just retry
the build of failed images instead of running the whole workflow again.

https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstrategyfail-fast

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@Artyop Artyop force-pushed the pr/artyop/fail-fast-ci-build branch from 12035d6 to 625dd8c Compare April 1, 2026 10:56
@Artyop Artyop requested a review from aanm April 1, 2026 10:56
@Artyop
Copy link
Copy Markdown
Contributor Author

Artyop commented Apr 1, 2026

/test

@aanm aanm added this pull request to the merge queue Apr 1, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 1, 2026
Merged via the queue into main with commit 86ed057 Apr 1, 2026
81 of 83 checks passed
@aanm aanm deleted the pr/artyop/fail-fast-ci-build branch April 1, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants