.github/workflows: replace external set-commit-status action#45078
Merged
Conversation
Member
Author
|
/test |
Replace myrotvorets/set-commit-status-action with an in-repo composite action to prevent the Node.js 20 deprecation warning: Warning: Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: myrotvorets/set-commit-status-action@3730c0a. The set-commit-status action is simple enough (a single GitHub API call) that we don't need to depend on an external dependency for it. Signed-off-by: André Martins <andre@cilium.io>
|
/test |
2f628fc to
b25f17e
Compare
Member
Author
|
/test |
devodev
approved these changes
Mar 31, 2026
Artyop
approved these changes
Mar 31, 2026
Contributor
Artyop
left a comment
There was a problem hiding this comment.
using gh api instead of an external action using a typescript library? Nice 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace myrotvorets/set-commit-status-action with an in-repo composite
action to prevent the Node.js 20 deprecation warning:
Warning: Node.js 20 actions are deprecated. The following actions are
running on Node.js 20 and may not work as expected:
myrotvorets/set-commit-status-action@3730c0a.
The set-commit-status action is simple enough (a single GitHub API call)
that we don't need to depend on an external dependency for it.
The tests have successfully passed in a test run https://github.com/cilium/cilium/actions/runs/23797204667
Until the PR is merged it's likely the tests will fail since the action doesn't exist on main.