Skip to content

Miscellaneous changes to the Conformance MCS-API workflow#45060

Merged
giorio94 merged 3 commits intomainfrom
pr/giorio94/main/gha-mcs-api-misc
Mar 30, 2026
Merged

Miscellaneous changes to the Conformance MCS-API workflow#45060
giorio94 merged 3 commits intomainfrom
pr/giorio94/main/gha-mcs-api-misc

Conversation

@giorio94
Copy link
Copy Markdown
Member

Please review commit by commit, and refer to the individual descriptions for additional details.

Similarly to the already existing clustermesh-related workflows, let's
make the target runner of each job configurable via the dedicated
environment variables, to allow for fine-tuning based on the amount
of resources actually needed by the given job.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
There's no need to run the Conformance MCS API workflow any time that
a commit is merged into the main branch; hence, let's switch it to run
periodically on schedule (in addition to as part of every PR), for
consistency with the vast majority of the other workflows.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
There's no need to explicitly include this workflow in the nightly list,
as all workflows part of the `/test` trigger are already automatically
triggered on schedule for the given branch (not applicable for main).

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 requested review from a team as code owners March 30, 2026 14:18
@giorio94 giorio94 added the area/CI Continuous Integration testing issue or flake label Mar 30, 2026
@giorio94 giorio94 requested a review from MrFreezeex March 30, 2026 14:18
@giorio94 giorio94 added area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Mar 30, 2026
@giorio94 giorio94 requested a review from nbusseneau March 30, 2026 14:18
@giorio94
Copy link
Copy Markdown
Member Author

/test

1 similar comment
@cilium-ariane
Copy link
Copy Markdown

cilium-ariane bot commented Mar 30, 2026

/test

Copy link
Copy Markdown
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco!

I mostly started from the gw-api workflow to setup this workflow. For my own understanding does that means that for the 2 and 3 commits we want to do something different for mcs-api or it means that other similar workflow (like the gw-api one) should ideally be changed too?

Copy link
Copy Markdown
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@giorio94
Copy link
Copy Markdown
Member Author

For my own understanding does that means that for the 2 and 3 commits we want to do something different for mcs-api or it means that other similar workflow (like the gw-api one) should ideally be changed too?

As for schedule vs push, I admit that we are not particularly consistent. There are a bunch of workflows that are only run on schedule (e.g., conformance l3-l4 and l7), a few only on push to main (e.g., conformance clustermesh), while the gateway API one on both apparently 😁.

AFAIK, the main rationale for triggering them on push was to get more frequent feedback to spot possible issues early. However, there are also a bunch of downsides in hindsight, including the fact that the number of runs depends on how may PRs get merged (which means that statistics are more difficult to extract, and it may have the opposite effect of being triggered very rarely during quiet periods of the year), it is inconsistent with stable branches (that are additionally triggered on schedule anyways), and requires adaptations when branching a new stable branch (i.e., the branch name in the push trigger). IMO it would be good to migrate the vast majority of workflows to schedule for consistency, but it is mostly a personal opinion (I haven't changed the other clustermesh ones here as that would need to be backported as well, but that's on my TODO list).

As for the third commit, yeah, that may be changed for the Gateway API one as well, I'm honestly not sure why it is explicitly listed there given that it is also included as part of the main /test trigger.

@giorio94 giorio94 enabled auto-merge March 30, 2026 16:14
@giorio94 giorio94 added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 6a96b76 Mar 30, 2026
669 of 686 checks passed
@giorio94 giorio94 deleted the pr/giorio94/main/gha-mcs-api-misc branch March 30, 2026 17:03
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants