bgp: Fix metadata update in ServiceReconciler#45049
Merged
YutaroHayakawa merged 1 commit intocilium:mainfrom Mar 30, 2026
Merged
bgp: Fix metadata update in ServiceReconciler#45049YutaroHayakawa merged 1 commit intocilium:mainfrom
YutaroHayakawa merged 1 commit intocilium:mainfrom
Conversation
Update metadata only after successful reconciliation, to avoid races upon reconciliation retry. Without this change, we could attempt a diff reconciliation as part of a retry for a full reconciliation, which could cause missing advertisements. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
Contributor
Author
|
/test |
YutaroHayakawa
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update metadata only after successful reconciliation, to avoid races upon reconciliation retry.
Without this change, we could attempt a diff reconciliation as part of a retry for a full reconciliation, which could cause missing advertisements.