ci: fix pr number check for base branch retrieval#45024
Merged
Conversation
Fixing bad changes in #45019 pr-number doesn't have the value of the stable branch but a replacement using hyphens instead of the standard dot. Instead of comparing pr-number and context-ref, verify that pr-number is an actual pr-number, if it isn't, assuming the dispatch isn't coming from a PR but Ariane's dispatch, so use the context-ref instead. Fixes #44914 Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
aanm
requested changes
Mar 27, 2026
Contributor
Author
|
/test |
aanm
approved these changes
Mar 27, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing bad changes in #45019 pr-number doesn't have the value of the stable branch but a replacement using hyphens instead of the standard dot.
Instead of comparing pr-number and context-ref, verify that pr-number is an actual pr-number, if it isn't, assuming the dispatch isn't coming from a PR but Ariane's dispatch, so use the context-ref instead.
Fixes #44914