Skip to content

ci: fix is-workflow-call check to handle empty input#45020

Merged
aanm merged 1 commit intomainfrom
pr/fix-e2e-upgrade-tests
Mar 30, 2026
Merged

ci: fix is-workflow-call check to handle empty input#45020
aanm merged 1 commit intomainfrom
pr/fix-e2e-upgrade-tests

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Mar 27, 2026

Change the condition from '= "false"' to '!= "true"' so that the schedule branch also matches when inputs.is-workflow-call is empty (direct schedule trigger, not a workflow_call).

Fixes: 95056cc ("conformance-{l3-l4,l7}: add scheduled runs")
Reported-by: Alasdair McWilliam alasdair.mcwilliam@isovalent.com
Suggested-by: Simone Magnani simone.magnani@isovalent.com

Change the condition from '= "false"' to '!= "true"' so that
the schedule branch also matches when inputs.is-workflow-call is
empty (direct schedule trigger, not a workflow_call).

Fixes: 95056cc ("conformance-{l3-l4,l7}: add scheduled runs")
Reported-by: Alasdair McWilliam <alasdair.mcwilliam@isovalent.com>
Suggested-by: Simone Magnani <simone.magnani@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm requested a review from a team as a code owner March 27, 2026 11:25
@aanm aanm added the kind/bug/CI This is a bug in the testing code. label Mar 27, 2026
@aanm aanm requested a review from a team as a code owner March 27, 2026 11:25
@aanm aanm added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Mar 27, 2026
@aanm aanm requested a review from brlbil March 27, 2026 11:25
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Mar 27, 2026

/test

@aanm aanm added the needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch label Mar 27, 2026
@aanm aanm enabled auto-merge March 27, 2026 11:26
@cilium-ariane
Copy link
Copy Markdown

cilium-ariane bot commented Mar 27, 2026

/test

@aanm aanm added this pull request to the merge queue Mar 30, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2026
Merged via the queue into main with commit 5ad312d Mar 30, 2026
89 checks passed
@aanm aanm deleted the pr/fix-e2e-upgrade-tests branch March 30, 2026 09:11
@viktor-kurchenko viktor-kurchenko added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 30, 2026
@github-actions github-actions bot added backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/CI Continuous Integration testing issue or flake backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants