.github/renovate: use builder container for generate-k8s-api in all r…#44996
Merged
.github/renovate: use builder container for generate-k8s-api in all r…#44996
Conversation
…ules The `make generate-k8s-api` target uses `$(GO)` in Makefile variable evaluations (e.g. `NATIVE_ARCH`) which run on the host before delegating to the builder container. In the Renovate executor environment, `go` is not in PATH, causing `go: command not found` errors during these evaluations. The goswagger rule already used `GO='contrib/scripts/builder.sh go'` for `generate-apis` but not for `generate-k8s-api`. The k8s.io dependency rules also lacked this override. This commit updates all three postUpgradeTasks callsites to use the builder container for `go` invocations, matching the pattern already used by `generate-apis`. Signed-off-by: André Martins <andre@cilium.io>
Member
Author
|
/test |
1 similar comment
|
/test |
Artyop
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ules
The
make generate-k8s-apitarget uses$(GO)in Makefile variable evaluations (e.g.NATIVE_ARCH) which run on the host before delegating to the builder container. In the Renovate executor environment,gois not in PATH, causinggo: command not founderrors during these evaluations.The goswagger rule already used
GO='contrib/scripts/builder.sh go'forgenerate-apisbut not forgenerate-k8s-api. The k8s.io dependency rules also lacked this override. This commit updates all three postUpgradeTasks callsites to use the builder container forgoinvocations, matching the pattern already used bygenerate-apis.