sockets: Ensure bpffs is mounted in TestPrivilegedSocketDestroyers#44979
Merged
christarazi merged 1 commit intomainfrom Mar 25, 2026
Merged
sockets: Ensure bpffs is mounted in TestPrivilegedSocketDestroyers#44979christarazi merged 1 commit intomainfrom
christarazi merged 1 commit intomainfrom
Conversation
The test pins BPF maps but never calls bpf.CheckOrMountFS(), unlike every other privileged test that pins maps. It only passes when a test from another package has already mounted bpffs in the same process (CheckOrMountFS uses sync.Once). This makes it flaky depending on test execution order. Fixes: #44976 Fixes: a4265ec ("sockets: Implement integration test for socket destroyers") Signed-off-by: Chris Tarazi <chris@isovalent.com>
Member
Author
|
/test |
1 similar comment
|
/test |
aspsk
approved these changes
Mar 25, 2026
Member
|
Thank you! Looks like this would also apply for v1.19 ? Adding the label, cc @jrife |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test pins BPF maps but never calls bpf.CheckOrMountFS(), unlike
every other privileged test that pins maps. It only passes when a
test from another package has already mounted bpffs in the same
process (CheckOrMountFS uses sync.Once). This makes it flaky
depending on test execution order.
Fixes: #44976