bpf: tests: simplify __lb_v4_upsert_service()#44911
Merged
julianwiedmann merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
12065b5 ("bpf: test: support service definition with mixed L4 proto values") added support for configuring a dual-scope SVC with mixed L4 proto values (the actual proto, and ANY). But we now always have L4 service differentiation, and 3091b2e ("bpf: tests: Remove redundant function") removed the helper for services with mixed L4 protos. Clean up the redundant `proto_int` parameter as well. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Member
Author
|
/test |
ajmmm
approved these changes
Mar 20, 2026
Member
ajmmm
left a comment
There was a problem hiding this comment.
I hadn't spotted that doubling up. Nice little cleanup!
Member
|
Is there a reason why only the v4 path had the scope-specific protocol, but v6 did not? |
Member
Author
I wondered about the same for a moment. And just blamed it on me being lazy back then. |
Member
Author
|
/test |
jrife
approved these changes
Mar 31, 2026
Contributor
jrife
left a comment
There was a problem hiding this comment.
Thanks, sorry for the delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
12065b5 ("bpf: test: support service definition with mixed L4 proto values") added support for configuring a dual-scope SVC with mixed L4 proto values (the actual proto, and ANY).
But we now always have L4 service differentiation, and 3091b2e ("bpf: tests: Remove redundant function") removed the helper for services with mixed L4 protos. Clean up the redundant
proto_intparameter as well.