Skip to content

bgp: Ensure ServerLogger uses BGP instance name#44910

Merged
YutaroHayakawa merged 1 commit intocilium:mainfrom
martonra:add-bgp-instance-name-to-bgp-logger
Mar 31, 2026
Merged

bgp: Ensure ServerLogger uses BGP instance name#44910
YutaroHayakawa merged 1 commit intocilium:mainfrom
martonra:add-bgp-instance-name-to-bgp-logger

Conversation

@martonra
Copy link
Copy Markdown
Contributor

@martonra martonra commented Mar 20, 2026 •
edited
Loading

Changed ServerLogger, LogParams, ServerParameters to contain BGP instance name because current BGP implementation uses instance name as the identifier in the CRD API.
Deleted the name parameter from NewBGPInstance because it is part of ServerParameters.

@martonra martonra requested a review from a team as a code owner March 20, 2026 14:52
@martonra martonra requested a review from rastislavs March 20, 2026 14:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 20, 2026
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 20, 2026
@martonra martonra force-pushed the add-bgp-instance-name-to-bgp-logger branch 3 times, most recently from afbb835 to 3af117e Compare March 23, 2026 14:49
rastislavs
rastislavs reviewed Mar 23, 2026
View reviewed changes
@martonra martonra force-pushed the add-bgp-instance-name-to-bgp-logger branch from 3af117e to da12d22 Compare March 26, 2026 13:57
@rastislavs rastislavs added the release-note/misc This PR makes changes that have no direct user impact. label Mar 26, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 26, 2026
@rastislavs rastislavs added the area/bgp Impacts the Border Gateway Protocol feature. label Mar 26, 2026
@rastislavs
Copy link
Copy Markdown
Contributor

rastislavs commented Mar 26, 2026

/test

YutaroHayakawa
YutaroHayakawa approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 26, 2026
@martonra
bgp: Ensure ServerLogger uses BGP instance name
60708b8 
Changed ServerLogger, LogParams, ServerParameters to contain BGP instance name because current BGP implementation uses instance name as the identifier in the CRD API.
Deleted the name parameter from NewBGPInstance because it is part of ServerParameters.

Signed-off-by: Marton Rasek <mrasek@isovalent.com>
@martonra martonra force-pushed the add-bgp-instance-name-to-bgp-logger branch from da12d22 to 60708b8 Compare March 30, 2026 11:01
@YutaroHayakawa
Copy link
Copy Markdown
Member

YutaroHayakawa commented Mar 30, 2026

/test

@YutaroHayakawa YutaroHayakawa removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2026
@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Mar 31, 2026
Merged via the queue into cilium:main with commit bb6392e Mar 31, 2026
80 of 81 checks passed
@christarazi christarazi mentioned this pull request Mar 31, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

@rastislavs rastislavs rastislavs approved these changes

Assignees

No one assigned

Labels

area/bgp Impacts the Border Gateway Protocol feature. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martonra @rastislavs @YutaroHayakawa @msune