bpf, datapath: switch identity mark option to runtime config#44905
Merged
bpf, datapath: switch identity mark option to runtime config#44905
Conversation
Member
Author
|
/test |
5938451 to
f64a003
Compare
julianwiedmann
requested changes
Mar 20, 2026
Member
julianwiedmann
left a comment
There was a problem hiding this comment.
Thank you! Some minor notes while browsing through.
Big :kudos: for spotting the duplicated complexity tests, very cool that we start to see the benefits there.
Convert ENABLE_IDENTITY_MARK to a runtime config variable. Signed-off-by: Tobias Klauser <tobias@cilium.io>
With recent conversions to runtime options, some of the complexity-test configurations became duplicates within the same version and same BPF program: 61 - bpf/complexity-tests/61/bpf_host/1.txt and bpf/complexity-tests/61/bpf_host/7.txt - bpf/complexity-tests/61/bpf_lxc/1.txt and bpf/complexity-tests/61/bpf_lxc/7.txt - bpf/complexity-tests/61/bpf_overlay/1.txt and bpf/complexity-tests/61/bpf_overlay/3.txt 510 - bpf/complexity-tests/510/bpf_host/1.txt and bpf/complexity-tests/510/bpf_host/7.txt - bpf/complexity-tests/510/bpf_lxc/1.txt and bpf/complexity-tests/510/bpf_lxc/7.txt - bpf/complexity-tests/510/bpf_overlay/1.txt and bpf/complexity-tests/510/bpf_overlay/3.txt netnext - bpf/complexity-tests/netnext/bpf_host/1.txt and bpf/complexity-tests/netnext/bpf_host/8.txt - bpf/complexity-tests/netnext/bpf_lxc/1.txt and bpf/complexity-tests/netnext/bpf_lxc/7.txt - bpf/complexity-tests/netnext/bpf_overlay/1.txt and bpf/complexity-tests/netnext/bpf_overlay/3.txt Remove the ones with the higher number and rename files so the numbering remains consecutive. Signed-off-by: Tobias Klauser <tobias@cilium.io>
f64a003 to
8f1c6d1
Compare
Member
Author
|
/test |
julianwiedmann
approved these changes
Mar 20, 2026
rgo3
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
ENABLE_IDENTITY_MARKto a runtime config variable.Also clean up some duplicate complexity-tests as a result, see 2nd commit.