lb: Skip nil slots during BPF map restore to prevent panic#44895
Merged
joamaki merged 1 commit intocilium:mainfrom Mar 23, 2026
Merged
lb: Skip nil slots during BPF map restore to prevent panic#44895joamaki merged 1 commit intocilium:mainfrom
joamaki merged 1 commit intocilium:mainfrom
Conversation
When iterating over backend slots in ResetAndRestore, some slots beyond the master's count may be nil. Accessing GetBackendID() on a nil slot causes a nil pointer dereference panic. Add a nil check to skip nil slots during the restore loop. Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
Closed
3 tasks
Contributor
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating over backend slots in ResetAndRestore, some slots beyond the master's count may be nil. Accessing
GetBackendID()on a nil slot causes a nil pointer dereference panic.Add a nil check to skip nil slots during the restore loop.
This adds a guard rail in case the slot is
nilto allow agent to recover and not stuck inCrashloopbackoffRelated: #44896