wal: Do not truncate in NewWriter#44886
Merged
joamaki merged 1 commit intocilium:mainfrom Mar 19, 2026
Merged
Conversation
Truncating the existing log opens up for races where the WAL is empty and we haven't re-populated it with e.g. [Compact]. It's also was not obvious to users of pkg/wal (e.g. me) that on restart one needs to ensure that the existing entries need to be replayed into the WAL as otherwise they disappear. Fix this by not truncating which keeps us appending to the log until [Compact] is called to reset log. Signed-off-by: Jussi Maki <jussi@isovalent.com>
dylandreimerink
approved these changes
Mar 19, 2026
dylandreimerink
approved these changes
Mar 19, 2026
Contributor
Author
|
/test |
1 similar comment
|
/test |
Member
|
This is not a bug fix that we have to backport? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncating the existing log opens up for races where the WAL is empty and we haven't re-populated it with e.g. [Compact]. It's also was not obvious to users of pkg/wal (e.g. me) that on restart one needs to ensure that the existing entries need to be replayed into the WAL as otherwise they disappear.
Fix this by not truncating which keeps us appending to the log until [Compact] is called to reset log.