Skip to content

[v1.18] Revert "loader: XDP attach type fallback logic"#44857

Merged
julianwiedmann merged 4 commits intov1.18from
pr/jwi/v1.18/gke-revert
Mar 23, 2026
Merged

[v1.18] Revert "loader: XDP attach type fallback logic"#44857
julianwiedmann merged 4 commits intov1.18from
pr/jwi/v1.18/gke-revert

Conversation

@julianwiedmann
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann commented Mar 18, 2026

This reverts #44499, resolving a hard breakage in GKE CI.

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Mar 18, 2026
@julianwiedmann
Copy link
Copy Markdown
Member Author

/ci-gke

@julianwiedmann julianwiedmann changed the title Pr/jwi/v1.18/gke revert [v1.18] Revert "loader: XDP attach type fallback logic" Mar 18, 2026
@julianwiedmann
Copy link
Copy Markdown
Member Author

/test

@julianwiedmann julianwiedmann added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Mar 18, 2026
@julianwiedmann julianwiedmann marked this pull request as ready for review March 18, 2026 15:56
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 18, 2026 15:56
@julianwiedmann julianwiedmann removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Mar 23, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 23, 2026
This reverts commit fbf6a4e.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This reverts commit a6585b7.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This reverts commit b37e336.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
This reverts commit a86419b.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the pr/jwi/v1.18/gke-revert branch from 1226c41 to 90724a9 Compare March 23, 2026 14:29
@sekhar-isovalent
Copy link
Copy Markdown
Contributor

@julianwiedmann - I was wondering why this PR was marked as dont-merge/wait-until-release and not marked as a release-blocker ? Trying to understand.

@aanm
Copy link
Copy Markdown
Member

aanm commented Mar 23, 2026

/test

@julianwiedmann
Copy link
Copy Markdown
Member Author

@julianwiedmann - I was wondering why this PR was marked as dont-merge/wait-until-release and not marked as a release-blocker ? Trying to understand.

Passing CI on GKE is currently not required. If it was, then "fails to start on GKE" would have been an automatic blocker in the release process (can't ship if we can't pass required CI ...).

@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 23, 2026
Merged via the queue into v1.18 with commit b860966 Mar 23, 2026
349 of 364 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/v1.18/gke-revert branch March 23, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants