Skip to content

[envoy] Rename embedded envoy test#44839

Merged
jrajahalme merged 1 commit intocilium:mainfrom
nezdolik:embedded-envoy-test-cleanup
Mar 19, 2026
Merged

[envoy] Rename embedded envoy test#44839
jrajahalme merged 1 commit intocilium:mainfrom
nezdolik:embedded-envoy-test-cleanup

Conversation

@nezdolik
Copy link
Copy Markdown
Contributor

Renamed embedded_envoy_test and relevant types/methods to better reflect the actual setup of the test. Also added explanatory comments.

@nezdolik nezdolik requested a review from a team as a code owner March 17, 2026 12:51
@nezdolik nezdolik requested a review from mhofstetter March 17, 2026 12:51
@maintainer-s-little-helper
Copy link
Copy Markdown

Commit 9ddbb01 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 17, 2026
Copy link
Copy Markdown
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like not all relevant changes have been pushed. and commit is not signed either.

@nezdolik nezdolik force-pushed the embedded-envoy-test-cleanup branch from 9ddbb01 to 67fba06 Compare March 17, 2026 14:12
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 17, 2026
@maintainer-s-little-helper
Copy link
Copy Markdown

Commit 3aabb93 does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 18, 2026
@nezdolik nezdolik force-pushed the embedded-envoy-test-cleanup branch from 3aabb93 to f10cdda Compare March 18, 2026 11:07
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 18, 2026
@nezdolik nezdolik added the release-note/misc This PR makes changes that have no direct user impact. label Mar 18, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 18, 2026
Signed-off-by: Kateryna Nezdolii <kateryna.nezdolii@isovalent.com>
@nezdolik nezdolik force-pushed the embedded-envoy-test-cleanup branch from f10cdda to e1ba2b4 Compare March 18, 2026 17:12
@nezdolik
Copy link
Copy Markdown
Contributor Author

/test

@jrajahalme jrajahalme enabled auto-merge March 19, 2026 09:25
@jrajahalme jrajahalme added this pull request to the merge queue Mar 19, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 19, 2026
Merged via the queue into cilium:main with commit 8c1f44d Mar 19, 2026
76 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants