fix(gateway-api): fixes silent ignore of GRPCRoute in allowedRoutes#44826
Merged
mhofstetter merged 1 commit intocilium:mainfrom Mar 18, 2026
Merged
Conversation
Member
|
/test |
mhofstetter
requested changes
Mar 17, 2026
Member
mhofstetter
left a comment
There was a problem hiding this comment.
Thanks for the contribution @eufriction!
Please fix the unused import issue - otherwise LGTM.
operator/pkg/gateway-api/helpers_test.go:10:2: "k8s.io/api/core/v1" imported as corev1 and not used
…or listener The function getGatewayKindForObject maps a route object to its Gateway API kind string. It handled HTTPRoute, TLSRoute, UDPRoute, and TCPRoute but was missing a case for GRPCRoute, causing it to return \"Unknown\". Traffic failed with no indication in the route status, which uses a separate code path (input.GetGVK()) and remained Accepted: True. Fixes cilium#44824 Signed-off-by: Martin Lindberg <203184076+eufriction@users.noreply.github.com>
8b43bc4 to
fd56dc3
Compare
Contributor
Author
Should be fixed now! Thanks for the swift response. |
Member
|
/test |
mhofstetter
approved these changes
Mar 18, 2026
Member
mhofstetter
left a comment
There was a problem hiding this comment.
LGTM, thanks!
(it seems that ci-eks is currently broken due to infra issues. i will check back and re-run once this is fixed 🤞 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function getGatewayKindForObject maps a route object to its Gateway API kind string. It handled HTTPRoute, TLSRoute, UDPRoute, and TCPRoute but was missing a case for GRPCRoute, causing it to return "Unknown".
Traffic failed with no indication in the route status, which uses a separate code path (input.GetGVK()) and remained Accepted: True.
Fixes: #44824