traffic distribution: support PreferSameZone and PreferSameNode#44771
Merged
dylandreimerink merged 4 commits intocilium:mainfrom Mar 27, 2026
Merged
traffic distribution: support PreferSameZone and PreferSameNode#44771dylandreimerink merged 4 commits intocilium:mainfrom
dylandreimerink merged 4 commits intocilium:mainfrom
Conversation
dylandreimerink
requested changes
Mar 16, 2026
Member
dylandreimerink
left a comment
There was a problem hiding this comment.
Changes look good to me.
But I would like to see the tests updated to add test coverage for this new logic. By adding a new case to https://github.com/cilium/cilium/blob/main/pkg/loadbalancer/tests/testdata/topology-aware.txtar or by creating a new script.
Member
Author
|
Sure, here you go! |
dylandreimerink
approved these changes
Mar 19, 2026
Member
|
/test |
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
Member
|
/test |
1 similar comment
|
/test |
3 tasks
Member
|
@raphink Please also extend the Cilium KPR docs with a new section on trafficDistribution, what options we support, and how the options are handled internally by Cilium regarding backends. Also some example config + cilium service list dump would be great so that users get a better picture. Also in future lets not do empty commit messages, but rather explain a bit more in detail what/how/why you've implemented it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.