clustermesh: fix MCS-API need update CRD#44738
Merged
MrFreezeex merged 3 commits intocilium:mainfrom Mar 16, 2026
Merged
Conversation
Member
Author
|
/test |
|
/test |
044beab to
6f4f676
Compare
Member
Author
|
/test |
6f4f676 to
d4e6819
Compare
Member
Author
|
/test |
1 similar comment
|
/test |
giorio94
reviewed
Mar 12, 2026
d4e6819 to
32df665
Compare
32df665 to
c6bab53
Compare
Member
Author
|
/test |
|
/test |
Try to make this function a bit more readable by always adding the current/target prefix depending on what CRD we are reading the info from. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
Everything calls the interface with the inverted arg as what was currently declared here. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
The MCS-API CRDs version label is supposed to increase while the schema version is reset on each version label upgrade. The previous version of this function was not stopping if the version label was higher and continued to check if the schema revision was higher or not. We also add new tests for this function to ensure that the behavior is correct. This commit also adapt the schema revision for the updated code style of the version check while not changing the underlying logic. Signed-off-by: Arthur Outhenin-Chalandre <git@mrfreezeex.fr>
c6bab53 to
557bc47
Compare
Member
Author
|
/test |
1 similar comment
|
/test |
joamaki
approved these changes
Mar 16, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two first commits are mainly cleanups, the real bugfix is on the third commit