Conversation
The ActiveMaps() method returns list of open CT maps. The list is used
by the GC routine. The routine passes relevant CT maps to the
PurgeOrphanNATEntries. The latter expects the TCP CT map to be the first
one:
ctMapTCP, ctMapAny := maps[i], maps[i+1]
However, the 3872944 commit changed the order of the maps in the
list. Bring it back, otherwise the PurgeOrphanNATEntries keeps deleting
valid NAT entries (as it cannot find in the CT map).
Fixes: 3872944 ("ct/map: introduce hive cell")
Signed-off-by: Martynas Pumputis <martynas@isovalent.com>
Member
Author
|
/test |
harsimran-pabla
approved these changes
Mar 11, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ActiveMaps() method returns list of open CT maps. The list is used by the GC routine. The routine passes relevant CT maps to the PurgeOrphanNATEntries. The latter expects the TCP CT map to be the first one:
However, the 3872944 commit changed the order of the maps in the list. Bring it back, otherwise the PurgeOrphanNATEntries keeps deleting valid NAT entries (as it cannot find in the CT map).
Fixes: 3872944 ("ct/map: introduce hive cell") (cc @mhofstetter)
NOTE: will make the code more robust in a subsequent PR.
Fix #44727