Skip to content

helm,docs: add configDriftDetection Helm values and documentation#44703

Merged
qmonnet merged 2 commits intocilium:mainfrom
PhilipSchmid:pr/philip/helm_configmap_drift_checker
Mar 19, 2026
Merged

helm,docs: add configDriftDetection Helm values and documentation#44703
qmonnet merged 2 commits intocilium:mainfrom
PhilipSchmid:pr/philip/helm_configmap_drift_checker

Conversation

@PhilipSchmid
Copy link
Copy Markdown
Contributor

@PhilipSchmid PhilipSchmid commented Mar 9, 2026

  • docs: document ConfigMap drift detection and cilium_drift_checker_config_delta metric
  • helm: expose ConfigMap drift detection as first-class Helm values

Follow-up PR for #36510

helm,docs: add configDriftDetection Helm values and documentation

Let's please also backport this to 1.18.

@PhilipSchmid PhilipSchmid requested review from a team as code owners March 9, 2026 21:01
@PhilipSchmid PhilipSchmid requested review from nebril and qmonnet March 9, 2026 21:01
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 9, 2026
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/helm_configmap_drift_checker branch 2 times, most recently from e898f7d to e9ce2e5 Compare March 9, 2026 21:19
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but you should probably mention the new Helm values in the upgrade notes (Documentation/operations/upgrade.rst, “New Options”).

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/helm Impacts helm charts and user deployment experience labels Mar 10, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 10, 2026
@nebril nebril added needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 10, 2026
Add a configDriftDetection value group (enabled, driftChecker,
ignoredKeys) that wires enable-dynamic-config, enable-drift-checker,
and ignore-flags-drift-checker into the cilium-config ConfigMap.

Signed-off-by: Philip Schmid <phisch@cisco.com>
* metric: cilium_drift_checker_config_delta

Signed-off-by: Philip Schmid <phisch@cisco.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/helm_configmap_drift_checker branch from e9ce2e5 to 55c945a Compare March 10, 2026 14:46
@PhilipSchmid
Copy link
Copy Markdown
Contributor Author

@qmonnet right, that's a good idea. Thanks for the hint! I just added it and git force pushed once again.

@PhilipSchmid PhilipSchmid requested a review from qmonnet March 10, 2026 14:47
Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@qmonnet
Copy link
Copy Markdown
Member

qmonnet commented Mar 10, 2026

/test

@qmonnet qmonnet enabled auto-merge March 10, 2026 14:57
@julianwiedmann
Copy link
Copy Markdown
Member

/test

@qmonnet qmonnet added this pull request to the merge queue Mar 19, 2026
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 19, 2026
Merged via the queue into cilium:main with commit 3393e10 Mar 19, 2026
77 of 81 checks passed
@tklauser tklauser mentioned this pull request Mar 24, 2026
4 tasks
@tklauser tklauser added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Mar 24, 2026
@tklauser tklauser mentioned this pull request Mar 24, 2026
5 tasks
@tklauser tklauser added backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. and removed needs-backport/1.19 This PR / issue needs backporting to the v1.19 branch labels Mar 24, 2026
@github-actions github-actions bot added backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. and removed backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. backport-pending/1.19 The backport for Cilium 1.19.x for this PR is in progress. labels Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/helm Impacts helm charts and user deployment experience area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. backport-done/1.19 The backport for Cilium 1.19.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants