ci: inline Go version in setup-go version#44654
Merged
Conversation
There is no point in defining the Go version in an dedicated env var as it is only used in a single place for the setup-go version. Set it there directly and move the renovate marker. This follows the approach most other workflows which need to install Go are taking. Also drop the env var from the scale-cleanup-kops.yaml workflow where it isn't used at all. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Member
Author
|
/test |
|
/test |
joestringer
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point in defining the Go version in an dedicated env var as it is only used in a single place for the setup-go version. Set it there directly and move the renovate marker. This follows the approach most other workflows which need to install Go are taking.
Also drop the env var from the scale-cleanup-kops.yaml workflow where it isn't used at all.