Documentation: fix CI to catch untracked generated files#44642
Merged
joestringer merged 1 commit intocilium:mainfrom Mar 6, 2026
Merged
Documentation: fix CI to catch untracked generated files#44642joestringer merged 1 commit intocilium:mainfrom
joestringer merged 1 commit intocilium:mainfrom
Conversation
joestringer
approved these changes
Mar 5, 2026
Member
|
/test |
When new commands are added or new documentation is generated, the scripts in Documentation/ check for diffs using 'git diff --quiet'. However, this does not catch new, untracked files. This can lead to CI passing even if required documentation files are missing from the PR (but generated during the CI run). This PR adds 'git add --intent-to-add' before the diff check to ensure new files are also considered. Signed-off-by: Zihong Zheng <zihongz@google.com>
3d7c556 to
f48e4d6
Compare
Member
|
I rebased the PR because smoke tests were consistently failing, and I suspect it's because of a runtime conflict with a patch merged after the base commit of the PR. Re-triggering tests. |
Member
|
/test |
qmonnet
reviewed
Mar 6, 2026
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When new commands are added or new documentation is generated, the scripts in Documentation/ check for diffs using 'git diff --quiet'. However, this does not catch new, untracked files. This can lead to CI passing even if required documentation files are missing from the PR (but generated during the CI run).
This PR adds 'git add --intent-to-add' before the diff check to ensure new files are also considered.
Fixes #44636