fix(policy): Fix CIDR exception validation in CIDR policy#44637
Merged
squeed merged 1 commit intocilium:mainfrom Mar 5, 2026
Merged
fix(policy): Fix CIDR exception validation in CIDR policy#44637squeed merged 1 commit intocilium:mainfrom
squeed merged 1 commit intocilium:mainfrom
Conversation
During validation added to consider prefix length too. Added unit test cases. Fixes: cilium#44614 Signed-off-by: Tsotne Chakhvadze <tsotne@google.com>
Contributor
Author
|
/test |
Contributor
Author
|
I don't see rocket emoji idk somehow it didn't trigger some actions? gonna try again |
Contributor
Author
|
/test |
Contributor
Author
|
/ci-clustermesh |
Contributor
Author
|
/ci-l7 |
Contributor
Author
|
/ci-gateway-api |
squeed
approved these changes
Mar 5, 2026
Contributor
squeed
left a comment
There was a problem hiding this comment.
In theory, we can also enforce this with CEL, but this seems fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During validation added to consider prefix length too.
Added unit test cases.
Fixes: #44614