Envoy: Cancel completions on proxy listeners removal#44597
Merged
jrajahalme merged 2 commits intocilium:mainfrom Mar 16, 2026
Merged
Conversation
Member
Author
|
/test |
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Cancel Network Policy completions when the last proxy listener is removed. This prevents hanging policy update waits in situations where it is known that the NPDS client has been stopped, and that no further ACKs or NACKs are to be received. Any pending completions are cancelled with nil error, as the NPDS cache updaters have no way of reacting to the listeners being removed. NPDS cache is still being updated for the eventual restart of the NPDS client when a new proxy listener is added. Mock metrics had ACK/NACK reversed, this is now fixed. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
2177436 to
6a0e040
Compare
Member
Author
|
rebased to fix merge conflicts |
Member
Author
|
/test |
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel Network Policy completions when the last proxy listener is removed. This prevents hanging policy update waits in situations where it is known that the NPDS client has been stopped, and that no further ACKs or NACKs are to be received. Any pending completions are cancelled with nil error, as the NPDS cache updaters have no way of reacting to the listeners being removed. NPDS cache is still being updated for the eventual restart of the NPDS client when a new proxy listener is added.
Mock metrics had ACK/NACK reversed, this is now fixed.
Fixes: #44543