gke: Generate clusterName with hashed run identifier#44547
Merged
Conversation
0e07d05 to
3d546f1
Compare
Member
Author
|
/ci-gke |
3d546f1 to
a243ed5
Compare
Member
Author
|
/ci-gke |
a243ed5 to
8aaead7
Compare
Member
Author
|
/ci-gke |
Member
Author
|
/test |
Artyop
approved these changes
Feb 27, 2026
Member
|
This works but I don't like the fact we can't easily recognize clusters anymore by their name. Can we find another way to make this work with the 32 char constraint while keeping some sense of what's what? 🤔 |
pchaigno
reviewed
Feb 27, 2026
Member
pchaigno
left a comment
There was a problem hiding this comment.
Sorry Yutaro, I didn't manage to get to this with the work event at the same time. Thanks for taking care of it!
I think I agree with Nicolas about readability. Maybe we can drop other parts? 👇
The Cilium's cluster name cluster name must be 32 character or less. With the current naming convention, it will exceed 32 characters in certain condition (e.g when the workflow is running in the fork that has a longer name). The change we introduced in #44406 increased the risk further. To reduce the risk of exceeding 32 characters, remove repository_owner and UID from the clusterName. This gives the sufficient entropy to avoid name collision. Fixes: #44406 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
8aaead7 to
2844b86
Compare
pchaigno
approved these changes
Mar 2, 2026
Member
|
/test |
pchaigno
reviewed
Mar 3, 2026
|
|
||
| env: | ||
| clusterName: ${{ github.repository_owner }}-${{ github.event.repository.name }}-${{ github.run_id }}-${{ inputs.UID }}-${{ github.run_attempt }} | ||
| clusterName: ${{ github.event.repository.name }}-${{ github.run_id }}-${{ github.run_attempt }} |
Member
There was a problem hiding this comment.
@YutaroHayakawa It looks like you removed the UID here by mistake and it just broke Conformance GKE on main. I'm sending a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cilium's cluster name cluster name must be 32 character or less. With the current naming convention, it will exceed 32 characters in certain condition (e.g when the workflow is running in the fork that has a longer name). The change we introduced in #44406 increased the risk further.
To reduce the risk of exceeding 32 characters, use sha256 hash of the run identifier part (trimmed down to the 7 character like Git short hash) for the clusterName.
Fixes: #44406